Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#55335 closed update (fixed)

hedgewars @0.9.22_1: request to update to 0.9.23

Reported by: l2dy (Zero King) Owned by: kencu (Ken)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryandesign (Ryan Carsten Schmidt)
Port: hedgewars

Description


Attachments (4)

hedgewars-0.9.23.diff (4.2 KB) - added by ryandesign (Ryan Carsten Schmidt) 7 years ago.
patch-0004-remove-hardcoded-stdlib-and-iokit-QTfrontend.diff (629 bytes) - added by ryandesign (Ryan Carsten Schmidt) 7 years ago.
patch-0005-remove-haskell-spec-constr.diff (516 bytes) - added by ryandesign (Ryan Carsten Schmidt) 7 years ago.
patch-0006-CMakeLists-delete-clang-search.diff (609 bytes) - added by ryandesign (Ryan Carsten Schmidt) 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by kencu (Ken)

Status: newaccepted

comment:2 Changed 7 years ago by kencu (Ken)

Summary: hedgewars @0.9.22_1: update to 0.9.23hedgewars @0.9.22_1: request to update to 0.9.23

Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: hedgewars-0.9.23.diff added

Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

comment:3 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Here's the best I can do for now.

I added ports for the new dependency hs-sandi and its dependency hs-stringsearch.

It fails to build:

[22 of 25] Compiling Actions          ( /opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-svn-trunk_games_hedgewars/hedgewars/work/hedgewars-src-0.9.23/gameServer/Actions.hs, /opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-svn-trunk_games_hedgewars/hedgewars/work/build/gameServer/Actions.o )

/opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-svn-trunk_games_hedgewars/hedgewars/work/hedgewars-src-0.9.23/gameServer/Actions.hs:534:48:
    Couldn't match expected type ‘[ClientIndex]’
                with actual type ‘Maybe ClientIndex’
    In the second argument of ‘($)’, namely ‘masterID r’
    In the first argument of ‘(>>=)’, namely
      ‘(mapM (client'sM rnc id) $ masterID r)’

/opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-svn-trunk_games_hedgewars/hedgewars/work/hedgewars-src-0.9.23/gameServer/Actions.hs:535:61:
    Couldn't match expected type ‘Maybe ClientInfo’
                with actual type ‘[ClientInfo]’
    In the first argument of ‘maybeNick’, namely ‘cn’
    In the second argument of ‘roomInfo’, namely ‘(maybeNick cn)’

I haven't worked with Haskell before and am not sure what to do about such a problem.

comment:4 Changed 7 years ago by kencu (Ken)

Thanks, yeah, I did that too, locally. It doesn't build the server version. The non-server version works fine. I talked to the hedgewars devs. They say our ghc version is too old. I'm not sure they are right about that. I think their code needs fixing. I have the updated, nonserver version sitting here in a branch, waiting to decide if I'll just push that, or wait a bit for a fix.

I don't see our ghc getting updated any time soon; I asked abt that on the mailing list abt a month ago.

comment:5 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

I saw this in the INSTALL.md file:

### Hedgewars Server dependencies

The Hedgewars Server is an **optional** separate application.
It provides the online lobby and allows players to create rooms.
You will also be able to launch the server from the frontend
(network play → local network → start server).

**Most players do not need this!**

So maybe the server should be turned off, and the server should be offered in a separate subport again in the future if and when it works again.

comment:6 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign added

comment:7 Changed 7 years ago by kencu (Ken)

comment:8 Changed 7 years ago by ken-cunningham-webuse

Resolution: fixed
Status: acceptedclosed

In febd53ca2b881198c8a76f56322f293884b28906/macports-ports:

hedgewars: update to 0.9.23

rearrange patches for new version
use Macports lua51 and phyfs
disable server as our ghc won't build this version
at the present time, at least
closes: #55335

comment:9 Changed 7 years ago by kencu (Ken)

@ thanks to Ryan for some input on this upgrade. Don't know why keybinder gets into the mess, but it conflicts, for sure.

We'll hopefully be able to re-enable the server at some point when ghc progresses. For now, that last version of hedgewars on MacOS has a working server, or you can use a Unix version to host a server.

Note: See TracTickets for help on using tickets.