gnome-internet-radio-locator 1.0.7 +quartz

[oleaamot (Ole Aamot)]

gnome-internet-radio-locator 1.0.7 is available for free under GNU General Public License version 3 (or later) from ​​​​​​​https://download.gnome.org/sources/gnome-internet-radio-locator/1.0/gnome-internet-radio-locator-1.0.7.tar.xz with Norwegian bokmål translation.

See the attached diff for the new Portfile against ​​​​​​​https://github.com/macports/macports-ports/blob/master/gnome/gnome-internet-radio-locator/Portfile

Best, Ole

[oleaamot (Ole Aamot)]

gnome-internet-radio-locator 1.0.7

[ryandesign (Ryan Carsten Schmidt)]

The update to 1.0.7 is fine, but the rest is not:

• There are two nested pre-configure blocks.
• You're enabling the gtk3 and x11 variants by default, but the port doesn't have any such variants. I'm assuming you meant to add them, but forgot?
• You're checking whether gtk3 is installed with +quartz by checking for the existence of a file; that method has been obsolete for years. Instead, please use PortGroup active_variants 1.1 (at the top of the Portfile) and require_active_variants gtk3 +quartz (in the quartz variant—assuming the quartz variant were changed to declare that it requires the thus far nonexistent gtk3 variant).
• I am assuming here that gnome-internet-radio-locator builds itself in some way differently when gtk3 is installed with quartz vs when it is not; otherwise, it wouldn't make sense to declare an empty quartz variant.

[oleaamot (Ole Aamot)]

I removed quartz from the Portfile. See #56306

Thanks.

[raimue (Rainer Müller)]

Superseded by #56306.