aolserver @4.5.1: error: conflicting types for 'getsubopt'

[ryandesign (Ryan Carsten Schmidt)]

​https://paste.macports.org/4d7b1c877e2a

In file included from master.c:38:
In file included from ./thread.h:42:
In file included from /opt/local/var/macports/build/_Users_travis_build_macports_macports-ports_www_aolserver/aolserver/work/aolserver-4.5.1/include/nsthread.h:136:
/usr/include/stdlib.h:210:6: error: conflicting types for 'getsubopt'
int      getsubopt(char **, char * const *, char **);
         ^
/usr/include/unistd.h:748:6: note: previous declaration is here
int      getsubopt(char **, char * const *, char **);
         ^

[tobypeterson]

Looks like broken system headers.

[tobypeterson]

Tcl headers do something bad if you build with -DNO_CONST (which aolserver does).

[tobypeterson]

In 342347b83c5431f172be7c8384d45c853b0e703e/macports-ports (master):

aolserver: Fix build with tcl 8.6.x

Resolves #57353

[ryandesign (Ryan Carsten Schmidt)]

I think you forgot to commit the patchfile!