Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#57354 closed update (fixed)

Portfile update for Port whizard

Reported by: Romendakil Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: whizard@…
Port: whizard

Description

Update from version 2.4.1 to 2.6.0:

--- Portfile.orig       2018-10-12 16:53:18.000000000 +0200
+++ Portfile    2018-10-12 16:53:11.000000000 +0200
@@ -1,12 +1,10 @@
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
-# $Id: Portfile 141303 2015-10-15 19:35:18Z dstrubbe@macports.org $
 
 PortSystem          1.0
 PortGroup           compilers 1.0
 
 name                whizard
-version             2.4.1
-revision            1
+version             2.6.4
 categories          science
 platforms           darwin
 maintainers         desy.de:juergen.reuter desy.de:whizard
@@ -28,11 +26,11 @@
                     possible. For more particles, there is the option to generate \
                     processes as decay cascades including complete spin correlations.
 
-homepage            http://whizard.hepforge.org/
-master_sites        http://www.hepforge.org/archive/whizard/
+homepage            https://whizard.hepforge.org/
+master_sites        https://whizard.hepforge.org/downloads/
 
-checksums           rmd160  1991bb95765129daa801e01adfdee8567061add1 \
-                    sha256  2c731eb7c8990fb8f9a2d477479bd2f720fb905ac320a1561d8ada33009e0734
+checksums           rmd160  8793fcea26a40626cacb3a85fdb8e7a4ef67c0cf
+                    sha256  58af39329f3445e36d0fbfea7010568cf3653a5b4d249cc1cd8ccfb04ceddfa5
 
 depends_build       port:ocaml
 
@@ -42,7 +40,7 @@
 
 # if clang is used with gfortran, fails to link -lgomp
 compilers.choose    cc cxx fc f77
-compilers.setup     require_fortran -clang -llvm -g95 -gfortran
+compilers.setup     require_fortran -clang -g95 -gfortran
 
 # make check doesn't work in general on El Capitan as long as SIP is activated as DYLD variables are not exported.
 if {${os.major} <= 14 && ${os.platform} eq "darwin"} {

Attachments (4)

Portfile-whizard.diff (1.6 KB) - added by Romendakil 6 years ago.
Improved version of Portfile patch
Portfile-whizard-diff (1.3 KB) - added by mf2k (Frank Schima) 6 years ago.
main.log (162.8 KB) - added by mf2k (Frank Schima) 6 years ago.
Portfile-whizard.2.diff (1.3 KB) - added by mf2k (Frank Schima) 6 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 6 years ago by mf2k (Frank Schima)

The Milestone field is for use by Macports team members only, please do not set it.

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Milestone: MacPorts 2.6.0
Version: 2.5.4

comment:3 Changed 6 years ago by mf2k (Frank Schima)

Thanks! Your patch is not against master, please make sure you are fully up to date and re-attach the patch. For instance, the # $Id: line is already not in the current Portfile.

Notes:

  • Add the size to the checksums line

comment:4 Changed 6 years ago by mf2k (Frank Schima)

Also, please add your GitHub handle to the maintainers line.

Changed 6 years ago by Romendakil

Attachment: Portfile-whizard.diff added

Improved version of Portfile patch

comment:5 Changed 6 years ago by Romendakil

I tried my best to follow your instructions. Here is the new patch file.

comment:6 Changed 6 years ago by mf2k (Frank Schima)

I see the following build error on Mojave:

:info:build WOXDR.cpp:14:10: fatal error: /usr/include/sys/types.h: No such file or directory
:info:build  #include "/usr/include/sys/types.h"
:info:build           ^~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build compilation terminated.
:info:build make[3]: *** [WOXDR.lo] Error 1

Not surprising given that there is no /usr/include/ directory in Mojave.

comment:7 Changed 6 years ago by mf2k (Frank Schima)

Attaching a fixed Portfile patch and main.log.

Changed 6 years ago by mf2k (Frank Schima)

Attachment: Portfile-whizard-diff added

Changed 6 years ago by mf2k (Frank Schima)

Attachment: main.log added

Changed 6 years ago by mf2k (Frank Schima)

Attachment: Portfile-whizard.2.diff added

comment:8 Changed 6 years ago by Romendakil

Good, now I get the logic of the maintainer tag. Concerning the error in the log files, well, under Mojave I do install the system headers, so I didn't recognise the problem.

comment:9 Changed 6 years ago by mf2k (Frank Schima)

The new directory is:

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include

It can be mostly retrieved by running:

xcrun --show-sdk-path

comment:10 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In 7e88cf271a1fb36fdc6eaf8eafe9d0d9067296d0/macports-ports (master):

whizard: Update to 2.6.4

Closes: #57354

comment:11 in reply to:  9 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

No need to do anything fancy. Just #include <sys/types.h> as normal instead of the weird #include "/usr/include/sys/types.h".

I also changed the master_sites to avoid http redirects.

comment:12 Changed 6 years ago by Romendakil

Thanks, I also thought that the C++ file doesn't need the absolute path for the header as it is a system header. I will change it in our code for the next release.

Note: See TracTickets for help on using tickets.