bfs @1.3.3 - not UsingTheRightCompiler

[kencu (Ken)]

bfs is a no-configure port, that for most builds just calls cc, whatever cc is.

Needs to set up a proper build environment, something like legacy-support or similar.

Some fixes have been partially done that are applying only to universal builds.

[ylluminarious (George Plymale II)]

Replying to kencu:

bfs is a no-configure port, that for most builds just calls cc, whatever cc is.

Needs to set up a proper build environment, something like legacy-support or similar.

Some fixes have been partially done that are applying only to universal builds.

Umm, I'm not exactly sure what the issue is here. Could you give a specific example of the code that you want changed?

[kencu (Ken)]

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_bfs/bfs/work/bfs-1.3.3" && /usr/bin/make -j4 -w release 

make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_bfs/bfs/work/bfs-1.3.3'

cc -D__EXTENSIONS__ -D_ATFILE_SOURCE -D_BSD_SOURCE -D_DARWIN_C_SOURCE -D_DEFAULT_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DBFS_VERSION=\"1.3.3\"  -std=c99 -g -Wall -Wmissing-declarations -Wstrict-prototypes -O3 -flto -DNDEBUG -MD -MP -MF bftw.d -c bftw.c -o bftw.o

it needs something like this added to the Portfile:

build.env           CXX="${configure.cxx}" \
                    CXXFLAGS="${configure.cxxflags} [get_canonical_archflags cxx]" \
                    CC="${configure.cc}" \
                    CFLAGS="${configure.cflags} [get_canonical_archflags cc]" \
                    LDFLAGS="${configure.ldflags}  [get_canonical_archflags ld]" \
                    PREFIX=${prefix}

but then also have to sort out the extras for +universal.

[kencu (Ken)]

I should say -- IMHO this should all happen in base, but it doesn't presently.

[kencu (Ken)]

See also <​https://trac.macports.org/wiki/UsingTheRightCompiler>

[ylluminarious (George Plymale II)]

Replying to kencu:

See also <​https://trac.macports.org/wiki/UsingTheRightCompiler>

Hmm, I thought this was already taken care of in ​the original PR for this port. You can check it out for details. Is there something different about this situation?

[kencu (Ken)]

I believe we have decided to leave this one as it is.

[jmroot (Joshua Root)]

In f6a5a7d95936f7561c2b49e2f22789722b9f1c25/macports-ports (master):

bfs: use correct compiler, arch flags

Fixes: #58167