#60161 closed defect (fixed)
fish @3.1.0: error: field has incomplete type 'struct itimerval'
| Reported by: | kencu (Ken) | Owned by: | kencu (Ken) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | l2dy (Zero King) |
| Port: | fish |
Description
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_shells_fish/fish/work/fish-3.1.0/src/expand.cpp:20: :info:build /usr/include/sys/proc.h:118:19: error: field has incomplete type 'struct itimerval' :info:build struct itimerval p_realtimer; /* Alarm timer. */
Attachments (2)
Change History (8)
Changed 5 years ago by kencu (Ken)
| Attachment: | fish-fail-1068-clang9.log added |
|---|
Changed 5 years ago by kencu (Ken)
| Attachment: | patch-fish-src-expand-sys-time.diff added |
|---|
comment:1 Changed 5 years ago by kencu (Ken)
comment:2 Changed 5 years ago by kencu (Ken)
looks like at least 10.12 and less need this patch. Probably fine to apply it always -- must be getting pulled in some other way on 10.14 and up. Not sure about 10.13 -- no buildbot at present.
comment:3 Changed 5 years ago by kencu (Ken)
| Owner: | set to kencu |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:4 Changed 5 years ago by l2dy (Zero King)
| Cc: | l2dy added |
|---|
Ken, can you report or PR this upstream? We would have one less patch to maintain if they merged it.
comment:5 Changed 5 years ago by l2dy (Zero King)
Oops, it's already fixed in https://github.com/fish-shell/fish-shell/commit/5d03ca9de0ed964e1a31845ff48fcb26b055c38c.
comment:6 Changed 5 years ago by kencu (Ken)
yep, checked that myself. They also added a comment for clang-format. We can remove our patch when they get around to a new release.
Note: See
TracTickets for help on using
tickets.
which systems need this? this was found on 10.6.8.