bash @5.0.16 builds on PPC Mac OS X 10.4.11, Tiger, with an error

[ballapete (Peter "Pete" Dyballa)]

/opt/local/bin/gcc-apple-4.2 -fno-common -DHAVE_CONFIG_H -DSHELL -DMACOSX -pipe -Os -DSSH_SOURCE_BASHRC -arch ppc -Wno-parentheses -Wno-format-security -I. -I.. -I../.. -I../../lib -I../../builtins -I. -I../../include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_shells_bash/bash/work/bash-5.0 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_shells_bash/bash/work/bash-5.0/lib -I/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_shells_bash/bash/work/bash-5.0/builtins  -c -o fdflags.o fdflags.c
fdflags.c: In function 'getflags':
fdflags.c:117: error: 'O_CLOEXEC' undeclared (first use in this function)
fdflags.c:117: error: (Each undeclared identifier is reported only once
fdflags.c:117: error: for each function it appears in.)
fdflags.c: In function 'setone':
fdflags.c:202: error: 'O_CLOEXEC' undeclared (first use in this function)
make[1]: *** [fdflags.o] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_shells_bash/bash/work/bash-5.0/examples/loadables'
make: [install] Error 2 (ignored)
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_shells_bash/bash/work/bash-5.0'
DEBUG: Executing portdestroot::destroot_finish
DEBUG: Deleting stray share/info/dir file.
DEBUG: Fixing glibtool .la files in destroot for bash
--->  Compressing man pages for bash

Build continues and finishes.

[kencu (Ken)]

legacy-support has that defined on systems that need it...

[ballapete (Peter "Pete" Dyballa)]

Replying to kencu:

legacy-support has that defined on systems that need it...

So this needs to be added to Portfile, I think…

[kencu (Ken)]

would you like to test that and report back if it works?

[ballapete (Peter "Pete" Dyballa)]

Replying to kencu:

After some sleep and after installation of python38 has finished!

[ballapete (Peter "Pete" Dyballa)]

Interestingly this error does not repeat, neither with the original Portfile nor with a patched version that contains PortGroup legacysupport 1.0. fdflags.c is only touched the very first time.

make check (I used port build) delivers differences when legacy support is used, additional errors

run-lastpipe
9c9
< 0 -- 0 0 0
---
> 1 -- 0 1 0

run-test
1d0
< test-tests: the test suite should not be run as root
49c48
< 1
---
> 0
71c70
< 1
---
> 0
75c74
< 1
---
> 0

or differences like (without legacy support)

222c222
< ./nameref11.sub: Zeile 39: RO: Schreibgeschützte Variable.
---
> ./nameref11.sub: line 39: RO: readonly variable
224c224
< ./nameref11.sub: Zeile 39: RO: `unset' nicht möglich: Schreibgeschützt variable
---
> ./nameref11.sub: line 39: RO: cannot unset: readonly variable

vs. (with legacy support)

222,224c222,224
< ./nameref11.sub: Zeile 39: RO: Schreibgeschützte Variable.
< ./nameref11.sub: Zeile 39: RO: `unset' nicht möglich: Schreibgeschützt variable
< ./nameref11.sub: Zeile 39: declare: RO_PID: Nicht gefunden.
---
> ./nameref11.sub: line 39: RO: readonly variable
> declare -r RO_PID
> ./nameref11.sub: line 39: RO: cannot unset: readonly variable

[raimue (Rainer Müller)]

Just to be clear, I assigned this to me as I maintain the port, but I will not work on this.

[kencu (Ken)]

I'm not sure there is anything to fix. bash updated for me on 10.6.8 without a hiccup:

$ port -v installed bash
The following ports are currently installed:
  bash @5.0.11_0 platform='darwin 10' archs='x86_64' date='2019-09-17T04:29:48-0700'
  bash @5.0.16_0 (active) platform='darwin 10' archs='x86_64' date='2020-03-03T22:58:23-0800'

let me try on Tiger, and if it's all good, we can close this.

[ballapete (Peter "Pete" Dyballa)]

bash @5.2.9 could be built and installed, so this ticket can be closed.