libedit @20210910-3.1_0: build failure with GCC 4.2 (duplicate symbol _getdelim)

[evanmiller (Evan Miller)]

:debug:clean Starting logging for libedit @20210910-3.1_0
:debug:sysinfo Mac OS X 10.4.11 (darwin/8.11.0) arch powerpc
:debug:sysinfo MacPorts 2.7.1
:debug:sysinfo Xcode 2.5
:debug:sysinfo SDK 10.4
:debug:sysinfo MACOSX_DEPLOYMENT_TARGET: 10.4

...

:info:build /bin/sh ../libtool  --tag=CC   --mode=link /opt/local/bin/gcc-apple-4.2 -std=gnu99  -pipe -Os -arch ppc -no-undefined -version-info 0:68:0 -L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc -o libedit.la -rpath /opt/local/lib chared.lo common.lo el.lo eln.lo emacs.lo hist.lo keymacro.lo map.lo chartype.lo parse.lo prompt.lo read.lo refresh.lo search.lo sig.lo terminal.lo tty.lo vi.lo wcsdup.lo tokenizer.lo tokenizern.lo history.lo historyn.lo filecomplete.lo readline.lo literal.lo   getline.lo   getline.lo   -lncurses
:info:build libtool: link: /opt/local/bin/gcc-apple-4.2 -std=gnu99 -dynamiclib  -o .libs/libedit.0.dylib  .libs/chared.o .libs/common.o .libs/el.o .libs/eln.o .libs/emacs.o .libs/hist.o .libs/keymacro.o .libs/map.o .libs/chartype.o .libs/parse.o .libs/prompt.o .libs/read.o .libs/refresh.o .libs/search.o .libs/sig.o .libs/terminal.o .libs/tty.o .libs/vi.o .libs/wcsdup.o .libs/tokenizer.o .libs/tokenizern.o .libs/history.o .libs/historyn.o .libs/filecomplete.o .libs/readline.o .libs/literal.o .libs/getline.o .libs/getline.o   -L/opt/local/lib -lncurses  -Os -arch ppc -Wl,-headerpad_max_install_names -arch ppc   -install_name  /opt/local/lib/libedit.0.dylib -compatibility_version 1 -current_version 1.68 -Wl,-single_module
:info:build ld: duplicate symbol _getdelim in .libs/getline.o and .libs/getline.o
:info:build collect2: ld returned 1 exit status
:info:build make[3]: *** [libedit.la] Error 1

Complete log to follow

[jmroot (Joshua Root)]

Duplicate symbol in the same file? I guess the fix is just to only specify the file once then?

[judaew (Vadym-Valdis Yudaiev)]

I removed two patches which no longer needed in ​https://github.com/macports/macports-ports/commit/72e1fb7f5464b2be99443dea5bcf7c07f9191949

It should fix this error, but I keep this ticket open to receive feedback from Evan Miller.

[evanmiller (Evan Miller)]

Builds now, thanks!

[judaew (Vadym-Valdis Yudaiev)]

You're welcome, thanks for the ticket.