yubico-piv-tool: fails to build with openssl3

[michael-j-oconnor]

yubico-piv-tool 2.2.0 fails to build with openssl3. It looks like there's a slightly newer version 2.2.1 that released nearly concurrently with openssl 3, but the relnotes weren't clear on whether or not openssl 3 was addressed.

:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_security_yubico-piv-tool/yubico-piv-tool/work/yubico-piv-tool-2.2.0/ykcs11/ykcs11.h:37:
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_security_yubico-piv-tool/yubico-piv-tool/work/yubico-piv-tool-2.2.0/ykcs11/openssl_types.h:34:
:info:build In file included from /opt/local/libexec/openssl3/include/openssl/bn.h:26:
:info:build In file included from /opt/local/libexec/openssl3/include/openssl/crypto.h:39:
:info:build /opt/local/libexec/openssl3/include/openssl/core.h:72:11: error: unknown type name 'OSSL_DISPATCH'
:info:build     const OSSL_DISPATCH *implementation;
:info:build           ^
:info:build /opt/local/libexec/openssl3/include/openssl/core.h:191:43: error: unknown type name 'OSSL_DISPATCH'

etc.

[Chris Jones <jonesc@…>]

In 1ed356411c108b892f5c090bdd395c865fe5d0f9/macports-ports (master):

yubico-piv-tool: update to 2.2.1, use openssl PG pinned to 1.1
Closes: #63945

[cjones051073 (Chris Jones)]

Note the above fixes the openssl issue (2.2.1 didn't work with v3 btw).

However, the build is still broken with an unrelated issue

cd /opt/local/var/macports/build/_Users_chris_Projects_MacPorts_ports_security_yubico-piv-tool/yubico-piv-tool/work/build/tool && /opt/local/bin/help2man -s1 -N -n Tool\ for\ managing\ Personal\ Identity\ Verification\ credentials\ on\ Yubikeys -o /opt/local/var/macports/build/_Users_chris_Projects_MacPorts_ports_security_yubico-piv-tool/yubico-piv-tool/work/yubico-piv-tool-2.2.1/tool/yubico-piv-tool.1 ./yubico-piv-tool
[100%] Built target test_ykcs11
sh: line 1: 50858 Abort trap: 6           ./yubico-piv-tool --help 2> /dev/null

running by hand

Oberon /opt/local/var/macports/build/_Users_chris_Projects_MacPorts_ports_security_yubico-piv-tool/yubico-piv-tool/work/build/tool > ./yubico-piv-tool
dyld[50864]: Library not loaded: /opt/local/lib/libykpiv.2.dylib
  Referenced from: /opt/local/var/macports/build/_Users_chris_Projects_MacPorts_ports_security_yubico-piv-tool/yubico-piv-tool/work/build/tool/yubico-piv-tool
  Reason: tried: '/opt/local/lib/libykpiv.2.dylib' (no such file), '/usr/local/lib/libykpiv.2.dylib' (no such file), '/usr/lib/libykpiv.2.dylib' (no such file)
zsh: abort      ./yubico-piv-tool

seems the build is trying to run its own tool before all the libraries it requires are fully installed.

If you see the same please open a new ticket so the maintainer can take a look.

[michael-j-oconnor]

I see the same build fail with 2.2.1 and opened #63948

[neverpanic (Clemens Lang)]

See ​https://github.com/macports/macports-ports/pull/12962 which fixes this correctly.

[neverpanic (Clemens Lang)]

In c20d25fb2585663c681f9f3e32f1750dee7e020a/macports-ports (master):

yubico-piv-tool: Fix incompatibility with openssl3

Fixes: #63945