Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#64602 closed defect (fixed)

libusb: Configuration logfiles contain indications of -Wimplicit-function-declaration in "strchr"

Reported by: judaew (Vadym-Valdis Yudaiev) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version: 2.7.1
Keywords: wimplicit-function-declaration Cc: judaew (Vadym-Valdis Yudaiev), larryv (Lawrence Velázquez)
Port: libusb autoconf

Description

--->  Configuring libusb
Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled:
  strchr: found in libusb-libusb-4622bfc/config.log

See #64590 and WimplicitFunctionDeclaration.

Attachments (1)

config.log (62.1 KB) - added by judaew (Vadym-Valdis Yudaiev) 3 years ago.

Download all attachments as: .zip

Change History (9)

Changed 3 years ago by judaew (Vadym-Valdis Yudaiev)

Attachment: config.log added

comment:1 Changed 3 years ago by michaelld (Michael Dickens)

Getting such an error may be intentional by the developer. In this case this is an intentional check to see if strchr is implicitly defined or not. The code is actually part of autoconf, not libusb. I have a patch to add a #warning to this test in AC; with this patch, we could tweak then Wimplicit-function-declaration port check for the warning to not report these specific messages (which I don't have a patch for yet). Beyond this patch, I'm not aware of a way of hiding theses messages.

comment:2 Changed 3 years ago by michaelld (Michael Dickens)

Port: autoconf added

comment:3 Changed 3 years ago by michaelld (Michael Dickens)

Cc: larryv added

comment:4 Changed 3 years ago by jmroot (Joshua Root)

Cc: larryv removed
Port: autoconf removed

You can add strchr to configure.checks.implicit_function_declaration.whitelist, but it's kind of a pain do to that for all ports that configure with autoconf >= 2.70 (and there's the perhaps unlikely but real possibility that this might hide a real problem with use of strchr in future).

comment:5 Changed 3 years ago by jmroot (Joshua Root)

Cc: larryv added
Port: autoconf added

Ugh sorry, Trac reverted some of your changes without being asked.

comment:6 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

configure.checks.implicit_function_declaration.whitelist-append strchr is indeed what I have been adding to ports in this situation.

comment:7 Changed 3 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: assignedclosed

In 83668d4a28d51fb72c01fb40db7d76d5bf4a5605/macports-ports (master):

libusb: ignore strchr implicit function test

This test is actually part of autoconf, and is intentional. Hence, ignore it here.

Closes: #64602

comment:8 Changed 3 years ago by judaew (Vadym-Valdis Yudaiev)

Thanks Michael and Joshua!

Note: See TracTickets for help on using tickets.