#66382 closed defect (fixed)
TeXShop @4.79 contains Sparkle updater, which reports that it's outdated
| Reported by: | cooljeanius (Eric Gallager) | Owned by: | Marius Schamschula <mschamschula@…> |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.8.0 |
| Keywords: | Cc: | Schamschula (Marius Schamschula) | |
| Port: | TeXShop |
Description
So, 2 separate bugs here: 1 is TeXShop using Sparkle, which MacPorts has tried to remove from other ports when possible, 2 is the update, which is confirmed by livecheck:
$ port -v livecheck TeXShop TeXShop seems to have been updated (port version: 4.79, new version: 5.04)
Attachments (1)
Change History (14)
Changed 2 years ago by cooljeanius (Eric Gallager)
| Attachment: | Screen Shot 2022-12-01 at 18.04.13.png added |
|---|
comment:1 Changed 2 years ago by Schamschula (Marius Schamschula)
Two things:
1) I'll have to disable livecheck for older macOS versions that are incompatible with TeXShop 5
2) TeXShop is the second GUI app I've run across to use Sparkle (owncloud-client is the other). I'll see if I can fix that.
comment:2 Changed 2 years ago by cooljeanius (Eric Gallager)
Another app where Sparkle had to be disabled/removed that you can look at for reference would be GitUp; see #63684
comment:3 Changed 2 years ago by Schamschula (Marius Schamschula)
If it were only this easy. I got rid of Sparkle in owncloud-client using cmake. TeXShop is an Xcode project.
comment:4 Changed 2 years ago by Schamschula (Marius Schamschula)
I emailed upstream and got instructions.
Unfortunately, it only works when applied manually.
I'm working on making it work programmatically.
comment:5 Changed 2 years ago by Schamschula (Marius Schamschula)
I've figured it out. I need to remove all references to Sparkle from TeXShop.xcodeproj/project.pbxproj.
However, I'll wait for the next version (5.08) to be released.
The patch may be unstable from release to release.
comment:6 follow-up: 7 Changed 2 years ago by Marius Schamschula <mschamschula@…>
| Owner: | set to Marius Schamschula <mschamschula@…> |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:7 Changed 13 months ago by cooljeanius (Eric Gallager)
Replying to Marius Schamschula <mschamschula@…>:
In 68d191c8fd077f48c1654760b2ad6951f0785ca3/macports-ports (master):
Unfortunately this only fixed it for the case where {${os.major} > 20}; when {${os.major} == 20} (i.e. the case I'm on), the port is still at version 4.79, and is still attempting to update via Sparkle.
comment:8 Changed 13 months ago by Schamschula (Marius Schamschula)
Thanks for the info. I'll look into that.
comment:9 follow-up: 10 Changed 13 months ago by Schamschula (Marius Schamschula)
I've looked at the git history, and found that I never had implemented a fix for TeXShop < 5.x.
The problem is that I can't test a fix on my local machines.
I need to know if Sparkle for TeXShop 4.79 is installed into the same hierarchy as of version 5.x. If so, the fix is easy.
comment:10 Changed 13 months ago by cooljeanius (Eric Gallager)
Replying to Schamschula:
I need to know if Sparkle for
TeXShop4.79 is installed into the same hierarchy as of version 5.x. If so, the fix is easy.
OK, how would I check that?
comment:11 Changed 13 months ago by Schamschula (Marius Schamschula)
Indeed, it's a bit complicated.
I downloaded the old source code and tried applying the current patches.
One file dosen't exist (but the functionality is likely elsewhere), and the other one needs a new (perhaps simpler) patch.
screenshot of TeXShop Sparkle updater prompt