#67705 closed defect (fixed)

scribus @1.4.8: gtdialogs.cpp: error: ordered comparison of pointer with integer zero ('const void*' and 'int')

Reported by: barracuda156 Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.8.1
Keywords: powerpc Cc:
Port: scribus

Description

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_print_scribus/scribus/work/scribus-1.4.8/scribus/gtdialogs.cpp: In member function 'bool gtDialogs::runImporterDialog(const QStringList&)':
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_print_scribus/scribus/work/scribus-1.4.8/scribus/gtdialogs.cpp:163:45: error: ordered comparison of pointer with integer zero ('const void*' and 'int')
  163 |                 if (importers.contains(res) > 0)
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~^~~

Change History (6)

comment:1 Changed 17 months ago by ryandesign (Ryan Carsten Schmidt)

Summary: scripus error on PPC: gtdialogs.cpp: error: ordered comparison of pointer with integer zero ('const void*' and 'int')scripus @1.4.8: gtdialogs.cpp: error: ordered comparison of pointer with integer zero ('const void*' and 'int')

This is unlikely to be specific to PowerPC and more likely to be specific to the use of newer compilers on any platform.

They fixed this in r22422 (committed March 6, 2018) so 1.5.4 (released April 27, 2018) and later probably contain the fix. You could confirm by installing the scribus-devel port which is at version 1.5.8.

The 1.5.x series is a development series so we should not update the scribus port to it and they have not backported this fix to the 1.4.x branch but we could backport it.

comment:2 Changed 17 months ago by ryandesign (Ryan Carsten Schmidt)

Summary: scripus @1.4.8: gtdialogs.cpp: error: ordered comparison of pointer with integer zero ('const void*' and 'int')scribus @1.4.8: gtdialogs.cpp: error: ordered comparison of pointer with integer zero ('const void*' and 'int')

comment:3 in reply to:  1 Changed 17 months ago by ryandesign (Ryan Carsten Schmidt)

Replying to ryandesign:

by installing the scribus-devel port which is at version 1.5.8.

Er, no, it is somewhere between 1.5.7 and 1.5.8 and it doesn't build due to an update of the poppler port. I'll try to update scribus-devel to 1.5.8 and fix that incompatibility.

comment:4 Changed 17 months ago by ryandesign (Ryan Carsten Schmidt)

scribus-devel is now updated to version 1.5.8, but as explored in #66704 it will not build on a system as old as yours.

comment:5 in reply to:  4 Changed 17 months ago by barracuda156

Replying to ryandesign:

scribus-devel is now updated to version 1.5.8, but as explored in #66704 it will not build on a system as old as yours.

Thank you for the detailed info!

Perhaps backporting is the only way, yes.

comment:6 Changed 17 months ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In bd398dc7bd1d81a7149892503e4f6a49b1715ba4/macports-ports (master):

scribus: Fix build on newer compilers and macOS versions

Closes: #64290
Closes: #67705

Note: See TracTickets for help on using tickets.