Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#68642 closed defect (fixed)

smokeping: patch-bin-smokeping_cgi.diff changes $cfg to $cfgfile, but the code requires $cfg

Reported by: sbytnar (Steven Bytnar) Owned by: sbytnar (Steven Bytnar)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt)
Port: smokeping

Description

This diff blob

-my $cfg = (shift @ARGV) || "$FindBin::Bin/../etc/config";                           
+my $cfgfile = "__PREFIX__/etc/smokeping/config";                                    

should be

-my $cfg = (shift @ARGV) || "$FindBin::Bin/../etc/config";                           
+my $cfg = "__PREFIX__/etc/smokeping/config";                                    

Without it, smokeping_cgi fails to run.

Attachments (1)

fixed-patch-bin-smokeping_cgi.diff (613 bytes) - added by sbytnar (Steven Bytnar) 12 months ago.
fixed patch file

Download all attachments as: .zip

Change History (5)

Changed 12 months ago by sbytnar (Steven Bytnar)

fixed patch file

comment:1 Changed 12 months ago by sbytnar (Steven Bytnar)

For reference, https://github.com/oetiker/SmokePing/blob/2.8.2/bin/smokeping_cgi#L20 is the line being changed, used at line 24.

comment:2 Changed 12 months ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Summary: smokeping/files/patch-bin-smokeping_cgi.diff changes $cfg to $cfgfile, but the code requires $cfgsmokeping: patch-bin-smokeping_cgi.diff changes $cfg to $cfgfile, but the code requires $cfg

Thanks. Looks like this was a copy/paste mistake made when the port was updated to 2.8.1.

comment:3 Changed 12 months ago by sbytnar (Steven Bytnar)

Owner: set to sbytnar
Resolution: fixed
Status: newclosed

In 225df6906a921e098fc4ccd85d047809742960ec/macports-ports (master):

smokeping: Fix copy-paste error in patchfile

Closes: #68642

comment:4 Changed 12 months ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign added
Note: See TracTickets for help on using tickets.