#68642 closed defect (fixed)
smokeping: patch-bin-smokeping_cgi.diff changes $cfg to $cfgfile, but the code requires $cfg
Reported by: | sbytnar (Steven Bytnar) | Owned by: | sbytnar (Steven Bytnar) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | ryandesign (Ryan Carsten Schmidt) |
Port: | smokeping |
Description
This diff blob
-my $cfg = (shift @ARGV) || "$FindBin::Bin/../etc/config"; +my $cfgfile = "__PREFIX__/etc/smokeping/config";
should be
-my $cfg = (shift @ARGV) || "$FindBin::Bin/../etc/config"; +my $cfg = "__PREFIX__/etc/smokeping/config";
Without it, smokeping_cgi fails to run.
Attachments (1)
Change History (5)
Changed 12 months ago by sbytnar (Steven Bytnar)
Attachment: | fixed-patch-bin-smokeping_cgi.diff added |
---|
comment:1 Changed 12 months ago by sbytnar (Steven Bytnar)
For reference, https://github.com/oetiker/SmokePing/blob/2.8.2/bin/smokeping_cgi#L20 is the line being changed, used at line 24.
comment:2 Changed 12 months ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | haspatch added |
---|---|
Summary: | smokeping/files/patch-bin-smokeping_cgi.diff changes $cfg to $cfgfile, but the code requires $cfg → smokeping: patch-bin-smokeping_cgi.diff changes $cfg to $cfgfile, but the code requires $cfg |
Thanks. Looks like this was a copy/paste mistake made when the port was updated to 2.8.1.
comment:3 Changed 12 months ago by sbytnar (Steven Bytnar)
Owner: | set to sbytnar |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:4 Changed 12 months ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign added |
---|
Note: See
TracTickets for help on using
tickets.
fixed patch file