py3*-sip4 installations are broken due to missing destroot target

[barracuda156]

py27-pyqt4 installs normally on the identical setup. py310-pyqt4 fails:

36-32% sudo port -v install py310-pyqt4
Warning: configured user/group macports does not exist, will build as root
--->  Computing dependencies for py310-pyqt4.
--->  Fetching distfiles for py310-pyqt4
--->  Verifying checksums for py310-pyqt4
--->  Checksumming PyQt4_gpl_mac-4.12.1.tar.gz
--->  Extracting py310-pyqt4
--->  Extracting PyQt4_gpl_mac-4.12.1.tar.gz
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work" && /usr/bin/gzip -dc '/opt/local/var/macports/distfiles/python/PyQt4_gpl_mac-4.12.1.tar.gz' | /usr/bin/gnutar --no-same-owner -xf - 
--->  Applying patches to py310-pyqt4
--->  Applying patch-configure.py.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work/PyQt4_gpl_mac-4.12.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/python/py-pyqt4/files/patch-configure.py.diff'
patching file configure.py
--->  Applying patch-add_ppc64.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work/PyQt4_gpl_mac-4.12.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/python/py-pyqt4/files/patch-add_ppc64.diff'
patching file configure.py
--->  Applying patch-fix-qt_apps_dir.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work/PyQt4_gpl_mac-4.12.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/python/py-pyqt4/files/patch-fix-qt_apps_dir.diff'
patching file examples/demos/qtdemo/menumanager.py
patching file examples/designer/plugins/plugins.py
--->  Patching configure.py: s|@@MACPORTS_PYTHON_FRAMEWORK@@|/opt/local/Library/Frameworks/Python.framework/Versions/3.10/Python|
--->  Patching menumanager.py: s|@QT_APPS_DIR@|/Applications/MacPorts/Qt4|
--->  Patching plugins.py: s|@QT_APPS_DIR@|/Applications/MacPorts/Qt4|
--->  Configuring py310-pyqt4
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work/PyQt4_gpl_mac-4.12.1" && /opt/local/Library/Frameworks/Python.framework/Versions/3.10/bin/python3.10 configure.py -q /opt/local/libexec/qt4/bin/qmake --verbose --confirm-license -e QtGui -e QtHelp -e QtMultimedia -e QtNetwork -e QtDeclarative -e QtOpenGL -e QtScript -e QtScriptTools -e QtSql -e QtSvg -e QtTest -e QtWebKit -e QtXml -e QtXmlPatterns -e QAxContainer -e QtDesigner --dbus=/opt/local/Library/Frameworks/Python.framework/Versions/3.10/include/python3.10/dbus-1.0 --no-qsci-api --sipdir=/opt/local/Library/Frameworks/Python.framework/Versions/3.10/share/sip/PyQt4 --use-arch=ppc CC=/usr/bin/gcc-4.2 CXX=/usr/bin/g++-4.2 LFLAGS="-F/opt/local/Library/Frameworks -L/opt/local/lib -Wl,-headerpad_max_install_names" CFLAGS="-Os -pipe" CXXFLAGS="-Os -pipe" 
Traceback (most recent call last):
  File "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work/PyQt4_gpl_mac-4.12.1/configure.py", line 27, in <module>
    import sipconfig
ModuleNotFoundError: No module named 'sipconfig'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_python_py-pyqt4/py310-pyqt4/work/PyQt4_gpl_mac-4.12.1" && /opt/local/Library/Frameworks/Python.framework/Versions/3.10/bin/python3.10 configure.py -q /opt/local/libexec/qt4/bin/qmake --verbose --confirm-license -e QtGui -e QtHelp -e QtMultimedia -e QtNetwork -e QtDeclarative -e QtOpenGL -e QtScript -e QtScriptTools -e QtSql -e QtSvg -e QtTest -e QtWebKit -e QtXml -e QtXmlPatterns -e QAxContainer -e QtDesigner --dbus=/opt/local/Library/Frameworks/Python.framework/Versions/3.10/include/python3.10/dbus-1.0 --no-qsci-api --sipdir=/opt/local/Library/Frameworks/Python.framework/Versions/3.10/share/sip/PyQt4 --use-arch=ppc CC=/usr/bin/gcc-4.2 CXX=/usr/bin/g++-4.2 LFLAGS="-F/opt/local/Library/Frameworks -L/opt/local/lib -Wl,-headerpad_max_install_names" CFLAGS="-Os -pipe" CXXFLAGS="-Os -pipe" 
Exit code: 1
Error: Failed to configure py310-pyqt4: configure failure: command execution failed

Default portfiles are being used for both.

[barracuda156]

No wonder, since all py3*-sip4 ports for some reason install only docs. That is, they do build everything, but nothing goes into destroot besides docs folder.

[barracuda156]

Compare this:

:debug:destroot Executing proc-pre-org.macports.destroot-destroot-0
:info:destroot xinstall: mkdir /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/share/doc/py27-sip4
:info:destroot xinstall: mkdir /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/share/doc/py27-sip4/examples
:debug:destroot Executing proc-pre-org.macports.destroot-destroot-1
:debug:destroot Executing org.macports.destroot (py27-sip4)
:debug:destroot Environment: 
:debug:destroot CC='/usr/bin/gcc-4.2'
:debug:destroot CC_PRINT_OPTIONS='YES'
:debug:destroot CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/.CC_PRINT_OPTIONS'
:debug:destroot CFLAGS='-isysroot/'
:debug:destroot CPATH='/opt/local/include'
:debug:destroot CXX='/usr/bin/g++-4.2'
:debug:destroot CXXFLAGS='-isysroot/'
:debug:destroot DEVELOPER_DIR='/Developer'
:debug:destroot LIBRARY_PATH='/opt/local/lib'
:debug:destroot MACOSX_DEPLOYMENT_TARGET='10.6'
:debug:destroot OBJC='/usr/bin/gcc-4.2'
:debug:destroot OBJCFLAGS='-isysroot/'
:debug:destroot SDKROOT='/'
:info:destroot Executing:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25" && make -w install DESTDIR=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot 
:debug:destroot system:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25" && make -w install DESTDIR=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot 
:info:destroot make: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25'
:info:destroot make[1]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/sipgen'
:info:destroot cp -f sip /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin/sip
:info:destroot cp -f /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/siplib/sip.h /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/sip.h
:info:destroot make[1]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/sipgen'
:info:destroot make[1]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/siplib'
:info:destroot cp -f sip.so /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sip.so
:info:destroot cp -f /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/sip.pyi /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sip.pyi
:info:destroot make[1]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/siplib'
:info:destroot cp -f sipconfig.py /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sipconfig.py
:info:destroot cp -f /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25/sipdistutils.py /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/destroot/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sipdistutils.py
:info:destroot make: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25'
:debug:destroot Executing proc-post-org.macports.destroot-destroot-0
:debug:destroot Executing proc-post-org.macports.destroot-destroot-1
:info:destroot xinstall: chdir(/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py27-sip4/work/sip-4.19.25)

to this:

:debug:destroot Executing proc-pre-org.macports.destroot-destroot-0
:info:destroot xinstall: mkdir /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/destroot/opt/local/share/doc/py38-sip4
:info:destroot xinstall: mkdir /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/destroot/opt/local/share/doc/py38-sip4/examples
:debug:destroot Executing proc-pre-org.macports.destroot-destroot-1
:debug:destroot Executing org.macports.destroot (py38-sip4)
:debug:destroot Environment: 
:debug:destroot CC_PRINT_OPTIONS='YES'
:debug:destroot CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/.CC_PRINT_OPTIONS'
:debug:destroot CPATH='/opt/local/include'
:debug:destroot DEVELOPER_DIR='/Developer'
:debug:destroot LIBRARY_PATH='/opt/local/lib'
:debug:destroot MACOSX_DEPLOYMENT_TARGET='10.6'
:debug:destroot SDKROOT='/'
:info:destroot Executing:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25" && make -w DESTDIR=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/destroot 
:debug:destroot system:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25" && make -w DESTDIR=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/destroot 
:info:destroot make: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25'
:info:destroot make[1]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25/sipgen'
:info:destroot make[1]: Nothing to be done for `all'.
:info:destroot make[1]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25/sipgen'
:info:destroot make[1]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25/siplib'
:info:destroot make[1]: Nothing to be done for `all'.
:info:destroot make[1]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25/siplib'
:info:destroot make: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25'
:debug:destroot Executing proc-post-org.macports.destroot-destroot-0
:debug:destroot Executing proc-post-org.macports.destroot-destroot-1
:info:destroot xinstall: chdir(/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_python_py-sip4/py38-sip4/work/sip-4.19.25)

Now, why??

[ryandesign (Ryan Carsten Schmidt)]

Does this apply to our binaries of py38-sip4 or only to what you built on your system? If the latter, can you attach the main.log file?

[barracuda156]

I have found a problem and a fix. With python 2.7 destroot uses make -w install, while with python 3.* it uses make -w. In result, it does not destroot correctly. Setting destroot.target install fixes the issue.

Now let me check if it does not break python 2.7 at the same time.

UPD. All good, with python 2.7 it is inconsequential. It still works correctly.

[barracuda156]

Replying to ryandesign:

Does this apply to our binaries of py38-sip4 or only to what you built on your system? If the latter, can you attach the main.log file?

Last update to py-pyqt4 was 2 years ago. Pythons have been updated many times since then. I do not think it is meaningful to rely on whatever was compiled back then on buildbots.

[barracuda156]

I can confirm it is broken generally. Will add a log from Sonoma now.

[ryandesign (Ryan Carsten Schmidt)]

Ok, so it got broken last month when the python portgroup switched the default for python.pep517 to on for python37 and later since the python portgroup only defaults destroot.target to install when python.pep517 is off.

[ryandesign (Ryan Carsten Schmidt)]

I see you submitted a PR for this: ​https://github.com/macports/macports-ports/pull/21240

[barracuda156]

In 3b2bb6e9f26c352b327105c217e6f4b1f03ece49/macports-ports (master):

py-sip4: unbreak installations with python 3.x

Fixes: #68643

[ryandesign (Ryan Carsten Schmidt)]

In defde9221b763cea4eec2f0212b61fe57ae3f881/macports-ports (master):

py-sip4: Increase revision

See: #68643