Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#69599 closed defect (fixed)

libtool: hardcode-m4.patch seems to introduce a minor issue

Reported by: TurtleWilly (Wilhelm Loves Their Turtles) Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: michaelld (Michael Dickens)
Port: libtool

Description

In the "hardcode-m4.patch" it does this:

+# GNU M4.
+M4=$lt_M4$
+

In the resulting libtool it generated this:

# GNU M4.
M4="/usr/local/bin/m4"$

The trailing dollar sign looks a bit out-of-place and unnecessary, albeit it doesn't seem to do any harm.

Change History (4)

comment:1 Changed 8 months ago by ryandesign (Ryan Carsten Schmidt)

Cc: michaelld added
Owner: set to larryv
Status: newassigned
Summary: hardcode-m4.patch seems to introduce a minor issuelibtool: hardcode-m4.patch seems to introduce a minor issue

Hmm, that line has been there since 2015.

comment:2 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

comment:3 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

In 968f4f97267f4c7c8d7089321c0e2a2823ea6b8e/macports-ports (master):

libtool: Remove stray $ after variable assignment

Closes: #69599

comment:4 Changed 7 months ago by TurtleWilly (Wilhelm Loves Their Turtles)

So much work for a single extra character!

Thanks for the fix!

Note: See TracTickets for help on using tickets.