libdeflate @1.20: fails on 10.7, 10.8, 10.9, 10.10

[Dave-Allured (Dave Allured)]

The recent update to libdeflate @1.20 fails on x86_64 builders for 10.7, 10.8, 10.9, 10.10. These all catch this newly added upstream error:

#  if !CLANG_PREREQ(3, 9, 8000000)
#    error "clang versions older than 3.9 are no longer supported"
#  endif

Which is not consistent with the four build configurations:

-- The C compiler identification is AppleClang 4.2.0.4250028
-- The C compiler identification is AppleClang 5.1.0.5030040
-- The C compiler identification is AppleClang 6.0.0.6000057
-- The C compiler identification is AppleClang 7.0.2.7000181

For reference, this upstream commit for the 1.20 release:
​https://github.com/ebiggers/libdeflate/commit/a83fb24e1cb0ec6b6fd53446c941013edf055192

[Dave-Allured (Dave Allured)]

Builder log for 10.10 x86_64

[ryandesign (Ryan Carsten Schmidt)]

If the compiler is llvm.org clang, then CLANG_PREREQ(3, 9, 8000000) checks if the version of clang is 3.9 or later, and if the compiler is Apple clang, then it checks if the version of clang is 8000000 (a.k.a 800 a.k.a 8.0.0) or later. So it's doing what it's programmed to do. Since it's not mentioned in the commit message, you could ask them to clarify if Apple clang 8000000 was indeed the intended version number. If so, we should blacklist {clang < 800}.

[ryandesign (Ryan Carsten Schmidt)]

I guess they did add to the readme in that commit: "clang: v3.9 and later (upstream), Xcode 8 and later (Apple)", so that does seem clear.

[Dave-Allured (Dave Allured)]

@ryandesign, thanks for the suggestion. Looks good to me. PR submitted:
​https://github.com/macports/macports-ports/pull/23239

[Dave-Allured (Dave Allured)]

In eb78f6dda3e02cc026d2a4fd851ed10c656dcfe9/macports-ports (master):

libdeflate: Fix builds for 10.7-10.10

.

• Fix Apple clang version numbering in blacklisting.
• Per suggestion in the following ticket.
• Closes #69600