Opened 4 months ago
Last modified 4 months ago
#69959 assigned defect
nrsc5 should not clone faad2 module but use MacPorts-provided faad2
| Reported by: | barracuda156 | Owned by: | trodemaster (Blake Garner) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.9.3 |
| Keywords: | Cc: | ||
| Port: | nrsc5 |
Description
The port declared a dependency on faad2 port, nevertheless it still clone external faad2:
---> Building nrsc5 Executing: cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build" && /usr/bin/make -j6 -w all VERBOSE=ON make: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build' /opt/local/bin/cmake -S/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/nrsc5-073726340ede83c596187f89d4442ab8d5180b77 -B/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build --check-build-system CMakeFiles/Makefile.cmake 0 /opt/local/bin/cmake -E cmake_progress_start /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/CMakeFiles /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build//CMakeFiles/progress.marks /usr/bin/make -f CMakeFiles/Makefile2 all make[1]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build' /usr/bin/make -f CMakeFiles/faad2_external.dir/build.make CMakeFiles/faad2_external.dir/depend make[2]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build' cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build && /opt/local/bin/cmake -E cmake_depends "Unix Makefiles" /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/nrsc5-073726340ede83c596187f89d4442ab8d5180b77 /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/nrsc5-073726340ede83c596187f89d4442ab8d5180b77 /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/CMakeFiles/faad2_external.dir/DependInfo.cmake "--color=" make[2]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build' /usr/bin/make -f CMakeFiles/faad2_external.dir/build.make CMakeFiles/faad2_external.dir/build make[2]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build' [ 3%] Creating directories for 'faad2_external' /opt/local/bin/cmake -Dcfgdir= -P /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/tmp/faad2_external-mkdirs.cmake /opt/local/bin/cmake -E touch /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external-stamp/faad2_external-mkdir [ 7%] Performing download step (git clone) for 'faad2_external' cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src && /opt/local/bin/cmake -P /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/tmp/faad2_external-gitclone.cmake Cloning into 'faad2_external'... HEAD is now at df42c6f main.c: aacFileName is always != NULL (#77) cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src && /opt/local/bin/cmake -E touch /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external-stamp/faad2_external-download [ 10%] No update step for 'faad2_external' cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external && /opt/local/bin/cmake -E echo_append cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external && /opt/local/bin/cmake -E touch /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external-stamp/faad2_external-update [ 14%] Performing patch step for 'faad2_external' cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external && patch -p1 -Ni /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/nrsc5-073726340ede83c596187f89d4442ab8d5180b77/support/faad2-hdc-support.patch || exit 0 patching file frontend/main.c patching file include/neaacdec.h patching file libfaad/Makefile.am patching file libfaad/bits.c patching file libfaad/bits.h patching file libfaad/common.c patching file libfaad/common.h patching file libfaad/decoder.c patching file libfaad/drm_dec.c patching file libfaad/drm_dec.h patching file libfaad/sbr_dec.c patching file libfaad/sbr_dec.h patching file libfaad/sbr_syntax.c patching file libfaad/syntax.c patching file libfaad/syntax.h cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external && sh ./bootstrap configure.ac:15: installing './compile' configure.ac:15: installing './config.guess' configure.ac:15: installing './config.sub' configure.ac:13: installing './install-sh' configure.ac:13: installing './missing' Makefile.am: installing './INSTALL' frontend/Makefile.am: installing './depcomp' configure.ac:15: warning: The macro 'AC_PROG_LIBTOOL' is obsolete. configure.ac:15: You should run autoupdate. aclocal.m4:122: AC_PROG_LIBTOOL is expanded from... configure.ac:15: the top level configure.ac:41: warning: The macro 'AC_HEADER_STDC' is obsolete. configure.ac:41: You should run autoupdate. ./lib/autoconf/headers.m4:663: AC_HEADER_STDC is expanded from... configure.ac:41: the top level configure.ac:47: warning: The macro 'AC_HEADER_TIME' is obsolete. configure.ac:47: You should run autoupdate. ./lib/autoconf/headers.m4:702: AC_HEADER_TIME is expanded from... configure.ac:47: the top level configure.ac:117: warning: The macro 'AC_TRY_LINK' is obsolete. configure.ac:117: You should run autoupdate. ./lib/autoconf/general.m4:2918: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:697: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... configure.ac:90: AC_C99_FUNC_LRINTF is expanded from... configure.ac:117: the top level configure.ac:119: warning: The macro 'AC_TRY_COMPILE' is obsolete. configure.ac:119: You should run autoupdate. ./lib/autoconf/general.m4:2845: AC_TRY_COMPILE is expanded from... configure.ac:64: MY_CHECK_TYPEDEF_FROM_INCLUDE is expanded from... configure.ac:119: the top level Ready to run ./configure cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external && /opt/local/bin/cmake -E touch /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external-stamp/faad2_external-patch [ 17%] Performing configure step for 'faad2_external' cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external-build && /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix/src/faad2_external/configure --host=powerpc-apple-darwin10 --prefix=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_audio_nrsc5/nrsc5/work/build/faad2-prefix "CFLAGS=-O2 -fPIC -pipe -Os -DNDEBUG -isystem/opt/local/include/LegacySupport -I/opt/local/include"
Change History (3)
comment:1 follow-up: 2 Changed 4 months ago by trodemaster (Blake Garner)
comment:2 Changed 4 months ago by barracuda156
Replying to trodemaster:
Related info from upstream project. https://github.com/theori-io/nrsc5/issues/340
The intel and Apple arches build correctly now. Does the recent PR updateing the ppc build resolve this.
Once my PR is merged, it will build, but I did not modify how it deals with dependencies. Apparently upstream wants it to use a bundled duplicate of faad2, but then we should remove a dependency on faad2 port. This is a separate issue from fixing ppc and old x86 build, I only address fixing the build in my PR.
comment:3 Changed 4 months ago by trodemaster (Blake Garner)
The behaviour of cloning faad2 was fixed for x86 and arm64 builds already. This build log is from a PPC system.
Note: See
TracTickets for help on using
tickets.
Related info from upstream project. https://github.com/theori-io/nrsc5/issues/340
The intel and Apple arches build correctly now. Does the recent PR updateing the ppc build resolve this.