ncftp: build failure: io_put.c:178:62: error: expected ')'

[i0ntempest]

The patch needs to be updated to patch a few occurences of main() to int main(), and then configure would succeed but build would fail with a bunch of missing closing brace errors.

There is also 3.2.7 available, the configure patch can be dropped for this version but it fails with a different error:

:info:build   /usr/bin/clang -D_REENTRANT -D_LARGEFILE64_SOURCE -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64 -Wno-format-y2k -DMACO
:info:build   SX -DHAVE_CONFIG_H -DMACOSX -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ncftp/ncft
:info:build   p/work/ncftp-3.2.7 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ncftp/ncftp/work/nc
:info:build   ftp-3.2.7/libncftp -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ncftp/ncftp/work/nc
:info:build   ftp-3.2.7/sio -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ncftp/ncftp/work/ncftp-3
:info:build   .2.7/Strn -I/oIn file included from Dynscpy.c:1:
:info:build   In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ncftp/ncftp/work/n
:info:build   cftp-3.2.7/Strn/syshdrs.h:64:
:info:build   In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/stdlib.h:66:
:info:build   In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/sys/wait.h:109:
:info:build   In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/sys/signal.h:82:
:info:build   In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/machine/signal.h:34:
:info:build   /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/arm/signal.h:17:13: error: cannot combine with previous 'int' declaration specifier
:info:build   typedef int sig_atomic_t;
:info:build               ^

I have both logs attached.

[jmroot (Joshua Root)]

Please remember to fill in the Port field.

[tobypeterson]

The sig_atomic_t error is because the configure patch cannot (entirely) be removed.

[tobypeterson]

It looks like 3.2.7 updated the configure script to include stdlib.h if HAVE_STDLIB_H is defined, but it's never defined.

[tobypeterson]

Even defining that doesn't make it correctly detect everything. Very messy - I'll need to spend more time looking at this.

[tobypeterson]

In c3dba40724294eaf07c3fa89f7efaa26d6b41227/macports-ports (master):

ncftp: update to 3.2.7

Fixes #70378