source-extractor @2.28.0: error: call to undeclared library function 'finite'

[cantiello (Michele Cantiello)]

Installing source-extractor on a macbook iOS with M3, I get the following error:

 sudo port install source-extractor 
--->  Computing dependencies for source-extractor
--->  Fetching archive for source-extractor
--->  Attempting to fetch source-extractor-2.28.0_0.darwin_23.arm64.tbz2 from https://packages.macports.org/source-extractor
--->  Attempting to fetch source-extractor-2.28.0_0.darwin_23.arm64.tbz2 from https://fra.de.packages.macports.org/source-extractor
--->  Attempting to fetch source-extractor-2.28.0_0.darwin_23.arm64.tbz2 from https://nue.de.packages.macports.org/source-extractor
--->  Building source-extractor
Error: Failed to build source-extractor: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_source-extractor/source-extractor/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port source-extractor failed

Mik

[ryandesign (Ryan Carsten Schmidt)]

source-extractor also fails to build on our arm64 build machines, but please attach the main.log file so that we can verify if it's the same problem.

[cantiello (Michele Cantiello)]

Replying to ryandesign:

source-extractor also fails to build on our arm64 build machines, but please attach the main.log file so that we can verify if it's the same problem.

Done!

Thanks

[ryandesign (Ryan Carsten Schmidt)]

Yup, same problem we see:

In file included from lm.c:81:
./lm_core.c:206:7: error: call to undeclared library function 'finite' with type 'int (double)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  if(!LM_FINITE(p_eL2)) stop=7;
      ^
./compiler.h:63:19: note: expanded from macro 'LM_FINITE'
#define LM_FINITE finite // ICC, GCC
                  ^
./lm_core.c:206:7: note: include the header <math.h> or explicitly provide a declaration for 'finite'
./compiler.h:63:19: note: expanded from macro 'LM_FINITE'
#define LM_FINITE finite // ICC, GCC
                  ^
In file included from lmbc.c:84:
./lmbc_core.c:324:13: error: call to undeclared library function 'finite' with type 'int (double)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
              if (!LM_FINITE(fpls)) {
                   ^
./compiler.h:63:19: note: expanded from macro 'LM_FINITE'
#define LM_FINITE finite // ICC, GCC
                  ^
./lmbc_core.c:324:13: note: include the header <math.h> or explicitly provide a declaration for 'finite'
./compiler.h:63:19: note: expanded from macro 'LM_FINITE'
#define LM_FINITE finite // ICC, GCC
                  ^
1 error generated.
1 error generated.

This was also filed upstream as ​https://github.com/astromatic/sextractor/issues/24 and again as ​https://github.com/astromatic/sextractor/issues/27. finite became obsolete in 1999 and is not included on Apple Silicon systems. The code needs to be changed to use isfinite instead. This was done in ​https://github.com/astromatic/sextractor/commit/ced65570cb5b7073361dbf2c3c60631c3f54d0f9 so we could backport that patch.

[ryandesign (Ryan Carsten Schmidt)]

In 76c82e0522805c9c96dd91d67a9070fc78ee41b9/macports-ports (master):

source-extractor: Use isfinite instead of finite

Closes: #71003