#71056 closed defect (fixed)
x265 @3.6: Does not install libx265.dylib nor x265.pc; causes other ports to fail to build
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | mascguy (Christopher Nielsen) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.10.2 |
Keywords: | snowleopard | Cc: | barracuda156, dbevans (David B. Evans), jeremyhu (Jeremy Huddleston Sequoia) |
Port: | x265 |
Description
- ffmpeg: https://build.macports.org/builders/ports-10.6_i386-builder/builds/182444/steps/install-port/logs/stdio
- ffmpeg6: https://build.macports.org/builders/ports-10.6_i386-builder/builds/182446/steps/install-port/logs/stdio
- ffmpeg7: https://build.macports.org/builders/ports-10.6_i386-builder/builds/182447/steps/install-port/logs/stdio
- ffmpeg-devel: https://build.macports.org/builders/ports-10.6_i386-builder/builds/182445/steps/install-port/logs/stdio
ERROR: x265 not found using pkg-config
Change History (8)
comment:1 Changed 5 hours ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | snowleopard added |
---|---|
Port: | x265 added; ffmpeg ffmpeg6 ffmpeg7 ffmpeg-devel removed |
Summary: | ffmpeg, ffmpeg6, ffmpeg7, ffmpeg-devel: ERROR: x265 not found using pkg-config → x265 @3.6: Does not install libx265.dylib; causes other ports to fail to build |
comment:2 Changed 5 hours ago by ryandesign (Ryan Carsten Schmidt)
Summary: | x265 @3.6: Does not install libx265.dylib; causes other ports to fail to build → x265 @3.6: Does not install libx265.dylib nor x265.pc; causes other ports to fail to build |
---|
comment:3 follow-up: 4 Changed 4 hours ago by ryandesign (Ryan Carsten Schmidt)
In the Mac OS X 10.6 log I see that it can't find git:
-- HG LIVE REPO STATUS CHECK DONE -- X265 RELEASE VERSION unknown
Maybe the fallback code for what to do when git is not found is broken.
In the macOS 13 log it finds git:
-- GIT_EXECUTABLE /usr/bin/git -- SOURCE CODE IS FROM x265 GIT ARCHIVED ZIP OR TAR BALL -- GIT ARCHIVAL INFORMATION PROCESSED -- X265 RELEASE VERSION 3.5+1-f0c1022b6
However the version number that it determines itself to be is wrong.
I am able to reproduce the problem if I add -DCMAKE_DISABLE_FIND_PACKAGE_Git=ON
to configure.args
on macOS 12.
The port is downloading an automatically-generated tarball from the x265 repository. The x265 project offers release downloads so we should be using those instead. Maybe they come pre-configured to know what version they are and don't need git. I will test.
comment:4 Changed 3 hours ago by barracuda156
Replying to ryandesign:
In the Mac OS X 10.6 log I see that it can't find git:
-- HG LIVE REPO STATUS CHECK DONE -- X265 RELEASE VERSION unknownMaybe the fallback code for what to do when git is not found is broken.
In the macOS 13 log it finds git:
-- GIT_EXECUTABLE /usr/bin/git -- SOURCE CODE IS FROM x265 GIT ARCHIVED ZIP OR TAR BALL -- GIT ARCHIVAL INFORMATION PROCESSED -- X265 RELEASE VERSION 3.5+1-f0c1022b6However the version number that it determines itself to be is wrong.
I am able to reproduce the problem if I add
-DCMAKE_DISABLE_FIND_PACKAGE_Git=ON
toconfigure.args
on macOS 12.The port is downloading an automatically-generated tarball from the x265 repository. The x265 project offers release downloads so we should be using those instead. Maybe they come pre-configured to know what version they are and don't need git. I will test.
If something is trying to use Apple-supplied git
, that will not work up to 10.8 (as I recall). MacPorts git
should be used instead.
(I have MacPorts built against bootstrapped git
, so I never have these problems locally on legacy systems.)
comment:5 follow-up: 6 Changed 3 hours ago by ryandesign (Ryan Carsten Schmidt)
git is being used only to inspect the local source directory, not to download anything, so I don't anticipate a problem with using the system git.
comment:6 Changed 3 hours ago by barracuda156
Replying to ryandesign:
git is being used only to inspect the local source directory, not to download anything, so I don't anticipate a problem with using the system git.
Well, at least on 10.6 ppc it built correctly: http://macos-powerpc.org/packages/x265/x265-3.6_0.darwin_10.ppc.tbz2 (And all dependents which I have revbumped or updated in that PR built as well.)
comment:7 follow-up: 8 Changed 3 hours ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
x265 @3.6, on Mac OS X 10.6 i386 at least, only installs libx265.a, not libx265.dylib.
https://build.macports.org/builders/ports-10.6_i386-builder/builds/182437/steps/install-port/logs/stdio
I don't see the same problem on macOS 13 arm64. Build machines for other OS versions have not yet gotten around to building the port.