x265 @3.6: Does not install libx265.dylib nor x265.pc; causes other ports to fail to build

[ryandesign (Ryan Carsten Schmidt)]

• ffmpeg: ​https://build.macports.org/builders/ports-10.6_i386-builder/builds/182444/steps/install-port/logs/stdio
• ffmpeg6: ​https://build.macports.org/builders/ports-10.6_i386-builder/builds/182446/steps/install-port/logs/stdio
• ffmpeg7: ​https://build.macports.org/builders/ports-10.6_i386-builder/builds/182447/steps/install-port/logs/stdio
• ffmpeg-devel: ​https://build.macports.org/builders/ports-10.6_i386-builder/builds/182445/steps/install-port/logs/stdio

ERROR: x265 not found using pkg-config

[ryandesign (Ryan Carsten Schmidt)]

x265 @3.6, on Mac OS X 10.6 i386 at least, only installs libx265.a, not libx265.dylib.

​https://build.macports.org/builders/ports-10.6_i386-builder/builds/182437/steps/install-port/logs/stdio

I don't see the same problem on macOS 13 arm64. Build machines for other OS versions have not yet gotten around to building the port.

[ryandesign (Ryan Carsten Schmidt)]

In the Mac OS X 10.6 log I see that it can't find git:

-- HG LIVE REPO STATUS CHECK DONE
-- X265 RELEASE VERSION unknown

Maybe the fallback code for what to do when git is not found is broken.

In the macOS 13 log it finds git:

-- GIT_EXECUTABLE /usr/bin/git
-- SOURCE CODE IS FROM x265 GIT ARCHIVED ZIP OR TAR BALL
-- GIT ARCHIVAL INFORMATION PROCESSED
-- X265 RELEASE VERSION 3.5+1-f0c1022b6

However the version number that it determines itself to be is wrong.

I am able to reproduce the problem if I add -DCMAKE_DISABLE_FIND_PACKAGE_Git=ON to configure.args on macOS 12.

The port is downloading an automatically-generated tarball from the x265 repository. The x265 project offers ​release downloads so we should be using those instead. Maybe they come pre-configured to know what version they are and don't need git. I will test.

[barracuda156]

Replying to ryandesign:

In the Mac OS X 10.6 log I see that it can't find git:

-- HG LIVE REPO STATUS CHECK DONE
-- X265 RELEASE VERSION unknown

Maybe the fallback code for what to do when git is not found is broken.

In the macOS 13 log it finds git:

-- GIT_EXECUTABLE /usr/bin/git
-- SOURCE CODE IS FROM x265 GIT ARCHIVED ZIP OR TAR BALL
-- GIT ARCHIVAL INFORMATION PROCESSED
-- X265 RELEASE VERSION 3.5+1-f0c1022b6

However the version number that it determines itself to be is wrong.

I am able to reproduce the problem if I add -DCMAKE_DISABLE_FIND_PACKAGE_Git=ON to configure.args on macOS 12.

The port is downloading an automatically-generated tarball from the x265 repository. The x265 project offers ​release downloads so we should be using those instead. Maybe they come pre-configured to know what version they are and don't need git. I will test.

If something is trying to use Apple-supplied git, that will not work up to 10.8 (as I recall). MacPorts git should be used instead. (I have MacPorts built against bootstrapped git, so I never have these problems locally on legacy systems.)

[ryandesign (Ryan Carsten Schmidt)]

git is being used only to inspect the local source directory, not to download anything, so I don't anticipate a problem with using the system git.

[barracuda156]

Replying to ryandesign:

git is being used only to inspect the local source directory, not to download anything, so I don't anticipate a problem with using the system git.

Well, at least on 10.6 ppc is built correctly: ​http://macos-powerpc.org/packages/x265/x265-3.6_0.darwin_10.ppc.tbz2 (And all dependents which I have revbumped or updated in that PR built as well.)

[ryandesign (Ryan Carsten Schmidt)]

In 99af437d1f41eb15874f926020fdcf39356a7ab2/macports-ports (master):

x265: Add git dep to install dylib and pc file

Add dependendency on git executable. Without it, libx265.dylib and
x265.pc are not installed. This primarily affects old Mac OS X versions
that do not come with git.

Closes: #71056

Remove license information from long description. Portfiles have a
separate license field to record license information.

Use the release download, not an automatically-generated tarball.

Set worksrcdir to a relative path, not an absolute one.

Avoid using system for things that can be done without it, like making
directories and renaming files.

Refresh patches.

[barracuda156]

Replying to ryandesign:

Thanks for fixing this.