libicns-0.7.0 Added support for OpenJPEG to Portfile

[verwymeren@…]

By default libicns builds using Jasper to add support for extracting 256x256 and 512x512 32-bit icons. Jasper frequently causes icns2png to generate errors when attempting to extract 256x256 and 512x512 icons. OpenJPEG appears to be more reliable so I suggest using it as the default library.

Attached is a Portfile that uses OpenJPEG as the default library and adds a Jasper variant if building against Jasper is preferred.

[verwymeren@…]

libicns Portfile diff

[adfernandes (Andrew Fernandes)]

Works for me... can we please

• add openmaintainer@… to the owner, and
• commit?

Thanks!

[blb@…]

Is there any value to linking to jasper instead of OpenJPEG? If not, can the variant be deleted?

[adfernandes (Andrew Fernandes)]

Replying to blb@…:

Is there any value to linking to jasper instead of OpenJPEG? If not, can the variant be deleted?

Hmm... perhaps the OpenJPEG version should be the default variant, rather than just deleting it. I'll work up a patch and test.

[verwymeren@…]

Replying to andrew@…:

Replying to blb@…:

Is there any value to linking to jasper instead of OpenJPEG? If not, can the variant be deleted?

Hmm... perhaps the OpenJPEG version should be the default variant, rather than just deleting it. I'll work up a patch and test.

Jasper doesn't work as well as OpenJPEG. I added the Jasper variant just in case someone prefers using it instead of OpenJPEG.

[adfernandes (Andrew Fernandes)]

Looks great - thank you!

Can someone please commit?

(I have a request to gain commit privs for myself on the mailing list...)

[mf2k (Frank Schima)]

Committed revision r57685.

[mathew.eis@…]

Hi all,

I am the upstream author of libicns - just came across this, and thought I could shed some light on a few things:

The instability you refer to when extracting icons using Jasper is due to a bug in the upstream libjasper. It can be fixed by changing two lines of code in libjasper; you can read more about the fix I proposed here: ​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=469786 (The actual upstream source for libjasper is here: ​http://www.ece.uvic.ca/~mdadams/jasper/ - but no longer appears to actively maintained.)

Also, the difference between using Jasper and OpenJPEG is that when using OpenJPEG libicns cannot yet create proper JP2 icons (those are the 256x256 and 512x512 sizes). With Jasper, it works perfectly (the extraction bug does not affect the creation of JP2 images)

Anyhow, it's up to you whether you prefer to link against Jasper or OpenJPEG; just make sure you understand the caveats of each - primarily being that you won't be able to generate 256x256 and 512x512 icons using OpenJPEG.

Hope that helps.

-Mathew Eis

[adfernandes (Andrew Fernandes)]

Thank you very, very much, Mathew... I'm opening a ticket to incorporate the debian patch you reference into macports. When that has been committed, I will change the default variant back to Jasper in a new ticket (I don't have authority to open/close/commit...)

I appreciate the detailed response you gave, BTW; my day job has very, very little to do with icons, so your detailed message was very handy. The patch request for jasper is #21675.

Cheers, -Andrew.

[adfernandes (Andrew Fernandes)]

Patch (well, reversion) ticket added as #21859. I decided to create a new ticket because this one's closed.

Once again, thanks, Mathew!