Add extra variants to postgresql90

[ddebernardy@…]

Similarly to #24684, there are a whole bunch of contrib modules in pgsql90 which aren't available when installing it using macports, and which would be really sweet -- either by default, or as variants.

In particular the unaccent contrib.

Alternatively, could there be a postgresql90-contrib package that bulk installs each and every one of them? Most people, I'm assuming, use macports on their laptops for local development, making it no big deal if more than what's strictly necessary gets installed.

[ddebernardy@…]

For information, I'm also running into a bug when using that contrib:

backend=# \i ./unaccent.sql 
SET
CREATE FUNCTION
CREATE FUNCTION
CREATE FUNCTION
CREATE FUNCTION
CREATE TEXT SEARCH TEMPLATE
psql:./unaccent.sql:34: WARNING:  duplicate TO argument, use first one
CONTEXT:  line 8 of configuration file "/opt/local/share/postgresql90/tsearch_data/unaccent.rules": "à	a
"
psql:./unaccent.sql:34: WARNING:  duplicate TO argument, use first one
CONTEXT:  line 57 of configuration file "/opt/local/share/postgresql90/tsearch_data/unaccent.rules": "Ġ	G
"
psql:./unaccent.sql:34: WARNING:  duplicate TO argument, use first one
CONTEXT:  line 144 of configuration file "/opt/local/share/postgresql90/tsearch_data/unaccent.rules": "Š	S
"
CREATE TEXT SEARCH DICTIONARY

backend=# select unaccent('Š');
WARNING:  duplicate TO argument, use first one
CONTEXT:  line 8 of configuration file "/opt/local/share/postgresql90/tsearch_data/unaccent.rules": "à	a
"
WARNING:  duplicate TO argument, use first one
CONTEXT:  line 57 of configuration file "/opt/local/share/postgresql90/tsearch_data/unaccent.rules": "Ġ	G
"
WARNING:  duplicate TO argument, use first one
CONTEXT:  line 144 of configuration file "/opt/local/share/postgresql90/tsearch_data/unaccent.rules": "Š	S
"
 unaccent 
----------
 Š
(1 row)

backend=# select unaccent('Š');
 unaccent 
----------
 Š
(1 row)

(the second call returns no warning, but still doesn't transform the string)

To add the contrib to the port, I added a variant to the portfile:

variant unaccent description {add unaccent contrib module} { 
	set contribs "${contribs} unaccent"
}

Followed by:

sudo port install postgresql +perl +unaccent

I've reported it upstream to Marc Fournier (postgresql dev).

[ddebernardy@…]

Said Marc:

You should take this up with the macports maintainer for this, as there may be a specific reason (ie. bugs below) why he didn't include it ... just tested here on redhat, and loads cleanly:

test=# \i ./unaccent.sql
SET
CREATE FUNCTION
CREATE FUNCTION
CREATE FUNCTION
CREATE FUNCTION
CREATE TEXT SEARCH TEMPLATE
CREATE TEXT SEARCH DICTIONARY

[ryandesign (Ryan Carsten Schmidt)]

Replying to ddebernardy@…:

In particular the unaccent contrib.

This one is available separately now; see #29427.

[ddebernardy@…]

Thanks for the notice.

Say, on a slightly related topic, postgresql 9.1 will be sporting extensions:

​http://developer.postgresql.org/pgdocs/postgres/extend-extensions.html

[ddebernardy@…]

Expanded diff (for Postgres 9.1):

--- Portfile.bak	2011-06-02 16:36:40.000000000 +0200
+++ Portfile	2011-06-02 16:54:42.000000000 +0200
@@ -75,7 +75,7 @@
 livecheck.regex	(9\\.1\[a-z\]+\[.0-9\]+)
 #livecheck.regex	(9\\.1\\.\[.0-9\]+)
 
-set contribs	"adminpack dblink fuzzystrmatch lo uuid-ossp pg_buffercache pg_trgm pgcrypto tsearch2 vacuumlo xml2"
+set contribs	"adminpack auto_explain cube dblink btree_gist btree_gin dict_xsyn file_fdw fuzzystrmatch hstore isn intagg intarray lo ltree pg_buffercache pgbench pgcrypto pgrowlocks pg_trgm pg_upgrade seg spi tsearch2 unaccent uuid-ossp vacuumlo xml2"
 
 post-build {
 	foreach contrib ${contribs} {

[francis@…]

Cc Me!

[jyrkiwahlstedt]

In their latest incarnations all ports build all contribs