Opened 12 years ago

Closed 6 years ago

#38397 closed submission (fixed)

new port: bowtie2

Reported by: sean@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: bowtie2

Description


Attachments (2)

Portfile (1.8 KB) - added by sean@… 12 years ago.
Updated
Portfile.2 (1.8 KB) - added by sean@… 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by cooljeanius (Eric Gallager)

port -v lint --nitpick reports the following warnings:

Warning: Line 2 is missing RCS tag ($Id$)
Warning: no license set

Also I'd add some manual line wrapping to the long_description there. And also generally openmaintainer goes last in the maintainers list. But those are just nitpicks; otherwise it looks good.

Changed 12 years ago by sean@…

Attachment: Portfile added

Updated

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Port: bowtie2 added

The destroot can be simplified to just:

destroot {
    xinstall -W ${worksrcpath} bowtie2 bowtie2-align bowtie2-build bowtie2-inspect ${destroot}${prefix}/bin
}

eval is not necessary because you're not evaluating any globs. 0755 is the default mode. xinstall can install multiple files at once.

Using use_configure no means you need to manually ensure you're UsingTheRightCompiler and -arch flags and add a universal variant if possible—unless this port doesn't build architecture-specific software, in which case you need supported_archs noarch.

When writing sourceforge master_sites you have to be sure to avoid redirects.

comment:3 Changed 12 years ago by larryv (Lawrence Velázquez)

If all you want to do is specify that the distfile has a different name than the default, don’t set distfiles; set distname instead, and leave off the extension. use_zip sets the correct extension for you. You’ll probably have to set worksrcdir back to ${name}-${version}.

Does the build seriously not support make install?

xinstall supports installing several files at once; you should do this instead of calling xinstall separately for each file. See the portfile(7) man page.

Changed 12 years ago by sean@…

Attachment: Portfile.2 added

comment:4 Changed 12 years ago by sean@…

Updated, thanks for the comments. I'll hold off on the others until this one is correct.

comment:5 Changed 6 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.1.3

This port was added at some point.

Note: See TracTickets for help on using tickets.