Opened 7 years ago
Closed 7 years ago
#55320 closed update (fixed)
Vcsn: 2.6 is out
Reported by: | akimd (Akim Demaille) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.4.2 |
Keywords: | haspatch maintainer | Cc: | |
Port: | vcsn |
Description
Hi!
This patch updates Vcsn.
Attachments (2)
Change History (9)
Changed 7 years ago by akimd (Akim Demaille)
comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | set to ryandesign |
---|---|
Status: | new → accepted |
comment:2 Changed 7 years ago by akimd (Akim Demaille)
Thanks Ryan. Sorry about that.
Just in case, I attached the right diff.
Changed 7 years ago by akimd (Akim Demaille)
Attachment: | vcsn.macports.diff added |
---|
comment:3 follow-up: 4 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
In this new diff, you've removed the flex dependency. Is it no longer needed? I still see references to flex in the code and flex still gets detected by the configure script.
It's probably safer to continue to append to the dependencies, rather than overwriting them. None of the portgroups you currently include have their own dependencies, but maybe they will in the future, or maybe you'll want to change to a portgroup that already does. For example, you might want to switch from the cxx11-1.0 portgroup to the cxx11-1.1 portgroup, which does add its own dependencies in some situations.
It seems like a new dependency yaml-cpp must be added; build fails without it.
Should we switch the python version to 3.6, since that's the latest version of python 3?
comment:4 Changed 7 years ago by akimd (Akim Demaille)
Replying to ryandesign:
In this new diff, you've removed the flex dependency. Is it no longer needed? I still see references to flex in the code and flex still gets detected by the configure script.
No, I'm just an idiot... Instead of starting from the Portfile as is known by MacPorts currently, I have stupidly made the diffs between MacPort and my local version, which was built from an obsolete copy of the Portfile.
IOW, I went too fast in trying to help, and generated BS and useless work on your side :(
It's probably safer to continue to append to the dependencies, rather than overwriting them. None of the portgroups you currently include have their own dependencies, but maybe they will in the future, or maybe you'll want to change to a portgroup that already does. For example, you might want to switch from the cxx11-1.0 portgroup to the cxx11-1.1 portgroup, which does add its own dependencies in some situations.
Please, do do whatever you think is right!
It seems like a new dependency yaml-cpp must be added; build fails without it.
Yes, indeed, it is. It worked on my side because it's installed.
Should we switch the python version to 3.6, since that's the latest version of python 3?
That's entirely up to you: it works with both, so the answer to the question is rather: let's pick up the most frequent one these days on MacPorts.
comment:5 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Turns out the port doesn't tell the build system what python version to use, so once I switched it to 3.6, while still having 3.5 installed, it ended up using 3.5 anyway. Fixing that now.
comment:7 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Thanks. For next time, please make sure your diff is made against the latest version of the Portfile in our repository.